git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 0/4] rev-parse: allow --flags to output rev-parse-like flags

From
Jon Seymour <jon.seymour@gmail.com>
Date
Sep 25, 2010, 13:33 UTC
Message-ID
<1285421633-22684-1-git-send-email-jon.seymour@gmail.com>

This series allows git rev-parse --flags to output remaining flag-like arguments even if such arguments are valid options to git rev-parse itself.

Previously:
  $ git rev-parse --flags -q -X --no-flags -- Y -Z
  -X
  $
Now:
  $ git rev-parse --flags -q -X --no-flags -- Y -Z
  -q -X --no-flags
  $

This series also changes the interpretation of --flags so that specification of this option implies --no-revs.

Previously:
  $ git rev-parse --flags HEAD
  HEAD
  $
Now:
  $ git rev-parse --flags HEAD
  $

Reviewers attention is drawn to the following behaviour which, while unchanged from current behaviour, differs from the behaviour specified by the documentation. Specifically:

  $ git rev-parse -X --no-flags
  -X
  $ git rev-parse --no-flags -X
  $

In other words, a git rev-parse option only ever affects the interpretation of succeeding options, never preceding options.

Aevar's feedback on v2 of this series has been incorporated.
Jon Seymour (4):
  rev-parse: stop interpreting flags as options to rev-parse once
    --flags is specified
  rev-parse: add tests for git rev-parse --flags.
  rev-parse: update documentation of --flags and --no-flags options
  rev-parse: make --flags imply --no-revs for remaining arguments.
 Documentation/git-rev-parse.txt |   12 ++++
 builtin/rev-parse.c             |   14 +++++-
 t/t1510-rev-parse-flags.sh      |  109 +++++++++++++++++++++++++++++++++++++++
 3 files changed, 134 insertions(+), 1 deletions(-)
 create mode 100755 t/t1510-rev-parse-flags.sh
-- 
1.7.3.3.gc4c52.dirty
Next: Jon Seymour
Message 1 of 8 in “rev-parse: allow --flags to output rev-parse-like flags”
  1. 0/4 rev-parse: allow --flags to output rev-parse-like flagsJon Seymour, Sep 25, 2010
  2. 1/4 rev-parse: stop interpreting flags as options to rev-parse once --flags is specifiedJon Seymour, Sep 25, 2010
  3. 2/4 rev-parse: add tests for git rev-parse --flags.Jon Seymour, Sep 25, 2010
  4. Ævar Arnfjörð BjarmasonSep 25, 2010
  5. Jon SeymourSep 25, 2010
  6. 3/4 rev-parse: update documentation of --flags and --no-flags optionsJon Seymour, Sep 25, 2010
  7. 4/4 rev-parse: make --flags imply --no-revs for remaining arguments.Jon Seymour, Sep 25, 2010
  8. Jon SeymourSep 25, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.