Re: Minimum Perl version?

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sep 24, 2010, 11:05 UTC
Message-ID: <AANLkTimUE=hyJ-y_XzpvCokb77KvRGw3gnM+9Xxui9tG@mail.gmail.com>
In-Reply-To: <AANLkTi=3xNSV0y-i=0KUSDRBJ8HmfSfGO7TBHTPiv_KM@mail.gmail.com>

On Fri, Sep 24, 2010 at 10:27, Tor Arntsen <tor@spacetec.no> wrote:

Show 15 quoted lines

> On Fri, Sep 24, 2010 at 12:00, Tait <git.git@t41t.com> wrote:
>>
>> What is the minimum Perl version git expects to support?
>>
>> I ask, because f922df8... seems to have introduced a open() syntax that
>> is not compatible with some older Perl versions.
>
> I've found that for add -p you'll need 5.8.x or newer, due to stuff like
>
>                my $fh = undef;
>                open($fh, '-|', @_) or die;
>
> which fails in e.g. perl 5.6.
> There could be some other stuff (in addition to add -p) that also does
> this kind of thing.

If that's the case (I don't have a 5.6 here to do archeology on) then git add -p never worked in 5.6. That was added in 5cde71d6 when it was introduced in 2006:

    +sub run_cmd_pipe {
    +       my $fh = undef;
    +       open($fh, '-|', @_) or die;
    +       return <$fh>;
    +}

Can you show us the specific error you're getting, and the output of your `perl -V` ?