Re: Minimum Perl version?

From: Tait <git.git@t41t.com>
Date: Sep 24, 2010, 20:40 UTC
Message-ID: <20100924204032.GU23563@ece.pdx.edu>
In-Reply-To: <AANLkTin_wrCnpz-fz=FuJ96j+xBHM1-5HTGG0vP7bmDY@mail.gmail.com>

Show 7 quoted lines

> > What is the minimum Perl version git expects to support?
> >
> > I ask, because f922df8... seems to have introduced a open() syntax that
> > is not compatible with some older Perl versions.
>
> We generally support 5.6 or above, but 5.8 or above for some other
> programs.

I am having to use a system with 5.6.1 to do cvsimport and cvsexportcommit, and interactive add. I haven't tried sendmail or other functions, yet. This system was previously using git 1.6.5.something, and did not have these problems as of that release, but now that I'm building git 1.7.3, they have appeared.

Perl 5.6.1 doesn't support the list open syntax, so one must replace open(my $fh, '-|', @list) with open(my $fh, '-|'), and then exec(@list). I'm working up a patch set to fill my own needs on this system, but based on the subsequent discussion about setting 5.8 as the minimum, it sounds like it's not worth submitting.

Thanks.