Re: [PATCH 02/16] list-objects: limit traversing within the given subtree if core.subtree is set
- From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
- Date
- Aug 1, 2010, 23:11 UTC
- Message-ID
- <AANLkTimSY4kv_i0HnBMCAwODkeFO3sV0tdxopcQwOfK8@mail.gmail.com>
- In-Reply-To
- <AANLkTinXhfSzVtcjHVzpdV_GUK+mbpVEezGY2aDXRk1-@mail.gmail.com>
2010/8/1 Ævar Arnfjörð Bjarmason <avarab@gmail.com>:
Show 5 quoted lines
>> + int subtree_len; > > Shouldn't that be size_t? strlen returns size_t, and strncmp expects > size_t, not int. >
Hmm.. yeah. The compiler didn't warn me. Anyway subtree_len should be small enough (i.e. < PATH_MAX) that type does not really matters.
-- Duy