Re: [PATCH] sha1_name: allow to add @{...} alias via config
2010/9/8 Santi Béjar <santi@agolina.net>:
Show 8 quoted lines
> 2010/9/8 Santi Béjar <santi@agolina.net>:
>> 2010/9/8 Nguyễn Thái Ngọc Duy <pclouds@gmail.com>:
>>> This allows users to add new @{..} alias via ref-at.* config
>>> variables. The rewrite rule is printf-alike.
>>
>> Another issue is that it can shadow builtin @{}s, like @{upstream}.
>
> In fact this patch breaks @{upstream}.My fault. There should not be an equal in
if (substitute_ref_at(&new_str, str) >= 0)
--
Duy