From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Wed, 08 Sep 2010 10:12:49 GMT
Subject: Re: [PATCH] sha1_name: allow to add @{...} alias via config
Message-ID: <AANLkTimR35gKwXg9Ve5y2SqaxyxcM410h3p=eM9cHWY2@mail.gmail.com>
In-Reply-To: <AANLkTin83BQ0YhWHuDqkY4HYWP9+bUso1BDNbFtRskDp@mail.gmail.com>

2010/9/8 Santi Béjar <santi@agolina.net>:
> 2010/9/8 Santi Béjar <santi@agolina.net>:
>> 2010/9/8 Nguyễn Thái Ngọc Duy <pclouds@gmail.com>:
>>> This allows users to add new @{..} alias via ref-at.* config
>>> variables. The rewrite rule is printf-alike.
>>
>> Another issue is that it can shadow builtin @{}s, like @{upstream}.
>
> In fact this patch breaks @{upstream}.

My fault. There should not be an equal in

if (substitute_ref_at(&new_str, str) >= 0)
-- 
Duy