Re: [PATCH 1/2] Add a new option 'core.askpass'.

From: Erik Faye-Lund <kusmabite@gmail.com>
Date: Aug 30, 2010, 12:17 UTC
Message-ID: <AANLkTimLzZpzgbY2tHVvZXRkhUCAnoGcgGM1eORhjaz=@mail.gmail.com>
In-Reply-To: <201008301344.22983.k.franke@science-computing.de>

On Mon, Aug 30, 2010 at 1:44 PM, Knut Franke <k.franke@science-computing.de> wrote:

Show 17 quoted lines

> On Friday 27 August 2010 19:28:38 Junio C Hamano wrote:
>> I don't see ASKPASS documented anywhere in the Documentation/ in the first
>> place.  Perhaps we would want to fix that while we are at it.
>
> It's at least mentioned in the core.askpass documentation added by the patch,
> but I'll try to improve.
>
> Incidentally, the documentation for other environment variables
> (GIT_PROXY_COMMAND, GIT_SSL_CERT, GIT_SSL_KEY, GIT_SSL_NO_VERIFY,
> GIT_SSL_CERT_PASSWORD_PROTECTED, GIT_SSL_CAINFO, GIT_SSL_CAPATH)
> is equally sparse.
>
>> Also this
>> does not feel like a "core." thing, but it may be just me.
>
> Where else could it go? It's not entirely http specific:
>

Perhaps "user.getpass"? But I have to admit, I agree with you that "core.askpass" is the most natural choice. It doesn't describe the user, it describes the mechanism to authenticate any user at any remote host, which IMO is much more a "core" matter.