Re: [PATCH 1/2] Add a new option 'core.askpass'.
- From
- Knut Franke <k.franke@science-computing.de>
- Date
- Aug 30, 2010, 11:44 UTC
- Message-ID
- <201008301344.22983.k.franke@science-computing.de>
- In-Reply-To
- <7vaao8hsmx.fsf@alter.siamese.dyndns.org>
On Friday 27 August 2010 19:28:38 Junio C Hamano wrote:
> I don't see ASKPASS documented anywhere in the Documentation/ in the first > place. Perhaps we would want to fix that while we are at it.
It's at least mentioned in the core.askpass documentation added by the patch, but I'll try to improve.
Incidentally, the documentation for other environment variables (GIT_PROXY_COMMAND, GIT_SSL_CERT, GIT_SSL_KEY, GIT_SSL_NO_VERIFY, GIT_SSL_CERT_PASSWORD_PROTECTED, GIT_SSL_CAINFO, GIT_SSL_CAPATH) is equally sparse.
> Also this > does not feel like a "core." thing, but it may be just me.
Where else could it go? It's not entirely http specific:
$ grep git_getpass *.c connect.c:char *git_getpass(const char *prompt) http.c: user_pass = xstrdup(git_getpass("Password: ")); http.c: ssl_cert_password = git_getpass("Certificate Password: "); http.c: * git_getpass is needed here because its very likely stdin/stdout are http.c: * but that is non-portable. Using git_getpass() can at least be stubbed http.c: user_name = xstrdup(git_getpass("Username: ")); imap-send.c: arg = git_getpass(prompt);
Nor does it relate to a single command.
-- Vorstand/Board of Management: Dr. Bernd Finkbeiner, Dr. Roland Niemeier, Dr. Arno Steitz, Dr. Ingrid Zech Vorsitzender des Aufsichtsrats/ Chairman of the Supervisory Board: Michel Lepert Sitz/Registered Office: Tuebingen Registergericht/Registration Court: Stuttgart Registernummer/Commercial Register No.: HRB 382196