git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [CGit] [PATCH 0/6] Communicate the repo name to the filter scripts

From
LHLars Hjemli <hjemli@gmail.com>
Date
Feb 19, 2011, 08:46 UTC
Message-ID
<AANLkTimASPjeHor3R6c=i1xpjftxrg4NnFaLJfReuZ-X@mail.gmail.com>
In-Reply-To
<1297977069-21884-1-git-send-email-mailings@hupie.com>
On Thu, Feb 17, 2011 at 22:11, Ferry Huberts <mailings@hupie.com> wrote:
> This patch series fixes two bugs and communicates the repo name
> to the filter scripts.

Thanks, but I think the current filter invocations with unnamed, positional command arguments was a mistake. We should probably fix it instead of extending it, taking care not to break backwards compatibility.

The easiest fix would be to add some environment variables:
* GIT_DIR
* CGIT_REPO_NAME
* CGIT_REPO_REL_URL
* CGIT_REPO_ABS_URL
* CGIT_BRANCH_NAME
* CGIT_COMMIT_ID
* CGIT_PATH_FILTER
What do you think?

-- larsh

Previous: Ferry HubertsNext: Ferry Huberts
Message 9 of 11 in “Communicate the repo name to the filter scripts”
  1. Ferry HubertsFeb 17, 2011
  2. [CGit] [PATCH 1/6] source_filter: fix a memory leakFerry Huberts, Feb 17, 2011
  3. [CGit] [PATCH 2/6] new_filter: correctly initialise all arguments for a new filterFerry Huberts, Feb 17, 2011
  4. [CGit] [PATCH 3/6] new_filter: determine extra_args from filter typeFerry Huberts, Feb 17, 2011
  5. [CGit] [PATCH 4/6] source_filter: also communicate the repo name to the filterFerry Huberts, Feb 17, 2011
  6. [CGit] [PATCH 5/6] commit_filter: also communicate the repo name to the filterFerry Huberts, Feb 17, 2011
  7. [CGit] [PATCH 6/6] about_filter: also communicate the repo name to the filterFerry Huberts, Feb 17, 2011
  8. Ferry HubertsFeb 17, 2011
  9. Lars HjemliFeb 19, 2011
  10. Ferry HubertsFeb 19, 2011
  11. Ferry HubertsFeb 24, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.