From: Lars Hjemli <hjemli@gmail.com>
Date: Sat, 19 Feb 2011 08:46:15 GMT
Subject: Re: [CGit] [PATCH 0/6] Communicate the repo name to the filter scripts
Message-ID: <AANLkTimASPjeHor3R6c=i1xpjftxrg4NnFaLJfReuZ-X@mail.gmail.com>
In-Reply-To: <1297977069-21884-1-git-send-email-mailings@hupie.com>

On Thu, Feb 17, 2011 at 22:11, Ferry Huberts <mailings@hupie.com> wrote:
> This patch series fixes two bugs and communicates the repo name
> to the filter scripts.

Thanks, but I think the current filter invocations with unnamed,
positional command arguments was a mistake. We should probably fix it
instead of extending it, taking care not to break backwards
compatibility.

The easiest fix would be to add some environment variables:
* GIT_DIR
* CGIT_REPO_NAME
* CGIT_REPO_REL_URL
* CGIT_REPO_ABS_URL
* CGIT_BRANCH_NAME
* CGIT_COMMIT_ID
* CGIT_PATH_FILTER

What do you think?

--
larsh