Re: [PATCH 2/6] Makefile: Include subdirectories in "make cover" reports

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Jul 24, 2010, 23:28 UTC
Message-ID: <AANLkTim8UIiplPxUdcEWnDpevOUUZARgObhIFCkfO3zl@mail.gmail.com>
In-Reply-To: <201007250037.57086.trast@student.ethz.ch>

On Sat, Jul 24, 2010 at 22:37, Thomas Rast <trast@student.ethz.ch> wrote:

Show 13 quoted lines

> Ævar Arnfjörð Bjarmason wrote:
>> The buildin/, xdiff/ and compat/ subdirectories weren't being included
>> in the gcov aggregation, nor were the files there being cleaned up.
> [...]
>>  coverage-clean:
>> -     rm -f *.gcda *.gcno
>> +     $(RM) *.gcov *.gcda *.gcno
>> +     $(RM) builtin/*.gcov
>> +     $(RM) builtin/*.gcda
>> +     $(RM) builtin/*.gcno
>
> By the same logic, the xdiff and compat directories should also be
> included here.  Maybe also block-sha1?

Yeah, actually now that I think about it any C code we compile could spew those *.gcda *.gcno files, which means:

    $ find . -type f -name '*.c'| ack '^(.*/.*)/[^/]+$' --output '$1'|sort|uniq
    ./block-sha1
    ./builtin
    ./compat
    ./compat/fnmatch
    ./compat/nedmalloc
    ./compat/regex
    ./compat/win32
    ./contrib/convert-objects
    ./contrib/examples
    ./contrib/svn-fe
    ./ppc
    ./xdiff

Maybe it would be better to just put:

    *.gcda
    *.gcno

Into .gitignore, and leave it to the user to clean these with git clean -dxf or something.