git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/6] Makefile: Include subdirectories in "make cover" reports

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Jul 24, 2010, 20:50 UTC
Message-ID
<1280004663-4887-3-git-send-email-avarab@gmail.com>
In-Reply-To
<1280004663-4887-1-git-send-email-avarab@gmail.com>

The buildin/, xdiff/ and compat/ subdirectories weren't being included in the gcov aggregation, nor were the files there being cleaned up.

Changed rm -f to the $(RM) variable while I was at it.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 Makefile |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index bc3c570..63f3f84 100644
--- a/Makefile
+++ b/Makefile
@@ -2281,7 +2281,10 @@ coverage:
 	$(MAKE) coverage-report
 
 coverage-clean:
-	rm -f *.gcda *.gcno
+	$(RM) *.gcov *.gcda *.gcno
+	$(RM) builtin/*.gcov
+	$(RM) builtin/*.gcda
+	$(RM) builtin/*.gcno
 
 COVERAGE_CFLAGS = $(CFLAGS) -O0 -ftest-coverage -fprofile-arcs
 COVERAGE_LDFLAGS = $(CFLAGS)  -O0 -lgcov
@@ -2293,6 +2296,9 @@ coverage-build: coverage-clean
 
 coverage-report:
 	gcov -b *.c
+	gcov -b -o builtin builtin/*.c
+	gcov -b -o xdiff xdiff/*.c
+	gcov -b -o compat compat/*.c
 	grep '^function.*called 0 ' *.c.gcov \
 		| sed -e 's/\([^:]*\)\.gcov: *function \([^ ]*\) called.*/\1: \2/' \
 		| tee coverage-untested-functions
-- 
1.7.0.4
Previous: Ævar Arnfjörð BjarmasonNext: Thomas Rast
Message 3 of 19 in “Detailed test coverage reports for Git”
  1. 0/6 Detailed test coverage reports for GitÆvar Arnfjörð Bjarmason, Jul 24, 2010
  2. 1/6 gitignore: Ignore files generated by "make coverage"Ævar Arnfjörð Bjarmason, Jul 24, 2010
  3. 2/6 Makefile: Include subdirectories in "make cover" reportsÆvar Arnfjörð Bjarmason, Jul 24, 2010
  4. Thomas RastJul 24, 2010
  5. Ævar Arnfjörð BjarmasonJul 24, 2010
  6. Jonathan NiederJul 24, 2010
  7. Junio C HamanoJul 26, 2010
  8. 3/6 Makefile: Split out the untested functions targetÆvar Arnfjörð Bjarmason, Jul 24, 2010
  9. Thomas RastJul 24, 2010
  10. Ævar Arnfjörð BjarmasonJul 24, 2010
  11. 4/6 Makefile: Add coverage-report-cover-db targetÆvar Arnfjörð Bjarmason, Jul 24, 2010
  12. Thomas RastJul 24, 2010
  13. Ævar Arnfjörð BjarmasonJul 24, 2010
  14. 5/6 Makefile: Add coverage-report-cover-db-html targetÆvar Arnfjörð Bjarmason, Jul 24, 2010
  15. 6/6 t/README: A new section about test coverageÆvar Arnfjörð Bjarmason, Jul 24, 2010
  16. Jonathan NiederJul 24, 2010
  17. Jonathan NiederJul 24, 2010
  18. Ævar Arnfjörð BjarmasonJul 24, 2010
  19. Jonathan NiederJul 24, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.