Re: [PATCH] git-gui: fix browser with initial path
Ping.
On Tue, Nov 23, 2010 at 08:37, Bert Wesarg <bert.wesarg@googlemail.com> wrote:
Show 33 quoted lines
> The path given to the browser does not end in a slash, which results in bad
> path given to blame and broke [Up To Parent]. Also the path was not
> escaped before displaying.
>
> Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
>
> ---
> git-gui/lib/browser.tcl | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/git-gui/lib/browser.tcl b/git-gui/lib/browser.tcl
> index c241572..a88a68b 100644
> --- a/git-gui/lib/browser.tcl
> +++ b/git-gui/lib/browser.tcl
> @@ -26,8 +26,14 @@ constructor new {commit {path {}}} {
> wm withdraw $top
> wm title $top [append "[appname] ([reponame]): " [mc "File Browser"]]
>
> + if {$path ne {}} {
> + if {[string index $path end] ne {/}} {
> + append path /
> + }
> + }
> +
> set browser_commit $commit
> - set browser_path $browser_commit:$path
> + set browser_path "$browser_commit:[escape_path $path]"
>
> ${NS}::label $w.path \
> -textvariable @browser_path \
> --
> tg: (6f10c41..) bw/git-gui/fix-browser-up (depends on: master)
>Bert Wesarg <bert.wesarg@googlemail.com>