Re: [PATCH] git-gui: fix browser with initial path
- From
Bert Wesarg <bert.wesarg@googlemail.com>
- Date
- Jan 28, 2011, 11:04 UTC
- Message-ID
- <AANLkTi=9vwg9mvvyWax0jr1OmAr+JUn7TNt98=9MxR6G@mail.gmail.com>
- In-Reply-To
- <87sjwdmhrs.fsf@fox.patthoyts.tk>
On Fri, Jan 28, 2011 at 11:42, Pat Thoyts <patthoyts@users.sourceforge.net> wrote:
Show 10 quoted lines
> The commit comment for this doesn't really reflect whats being > done. Commit 1ab8628 fixed the [Up To Parent] problem and this just > fixes the display on the browser title. > > So I plan to take this with the commit comment as: > > git-gui: fix display of path in browser title > > Ensure the browser path is shown on the title with a / suffix and escape > any backslashes or newlines in path elements before display.
No, the main problem is, that the path does not end in a slash, but the browser code expect this, ie. it build sub pathes by just concatenating '$path' and '$file', or with '$dir/', without a slash inbetween. Its not only the visual part. Try this without the patch (int git.git):
git gui browse git-gui/
In the path line there should be now 'master:git-gui'. Than go into 'lib'. You have 'master:git-guilib/'. And than double click about.tcl, The blame view will get the 'git-guilib/about.tcl'.
Because the browser is itself consistent in this behavior, the only problem was when the browser was a path given to start with. And this path needs have a trailing slash. And this patch ensures this.
Bert
Show 8 quoted lines
> > Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com> > > -- > Pat Thoyts http://www.patthoyts.tk/ > PGP fingerprint 2C 6E 98 07 2C 59 C8 97 10 CE 11 E6 04 E0 B9 DD > >