Re: [PATCH] Add ERR support to smart HTTP

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sep 6, 2010, 08:45 UTC
Message-ID: <AANLkTim-yfjACM_VqR2oaOaB=mLtD=+3QiXiWpwcdH1z@mail.gmail.com>
In-Reply-To: <AANLkTinTFWHWU1vCnDa-c3p5g+y7wnH9A8fieowQHU5z@mail.gmail.com>

On Mon, Sep 6, 2010 at 05:45, Sitaram Chamarty <sitaramc@gmail.com> wrote:

Show 22 quoted lines

> On Mon, Sep 6, 2010 at 6:34 AM, Sitaram Chamarty <sitaramc@gmail.com> wrote:
>> On Mon, Sep 6, 2010 at 2:52 AM, Jakub Narebski <jnareb@gmail.com> wrote:
>>> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>>>
>>>> On Sun, Sep 5, 2010 at 18:49, Ilari Liusvaara
>>>> <ilari.liusvaara@elisanet.fi> wrote:
>>>>
>>>> > AFAIK, HTTP errors don't have descriptions printed.
>>>>
>>>> I don't know if this applies here but HTTP error codes can come with
>>>> any free-form \n-delimited string:
>>>>
>>>>     HTTP/1.1 402 You Must Build Additional Pylons
>>>
>>> And you can also send more detailed description in the *body* (and not
>>> only HTTP headers) of HTTP response, though I don't know if git does
>>> that.
>
> turns out all this was moot.  It was *because* I was using something
> other than "200 OK" that the user was not seeing the message.  Ilari's
> patch just makes the message *look* better/cleaner, but I still have
> to send it out with a "200 OK" status.

You can still send it out with a "200 <anything you want here>" if you want to give a warning/error even on 200.