Re: [PATCH] Add ERR support to smart HTTP

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sep 5, 2010, 17:41 UTC
Message-ID: <20100905174105.GB14020@burratino>
In-Reply-To: <1283707815-32038-1-git-send-email-ilari.liusvaara@elisanet.fi>

Ilari Liusvaara wrote:

Show 13 quoted lines

> Thus for example server response:
> 
> "0031# ERR W access for foo/alice/a1 DENIED to bob"
> 
> Will cause the following to be printed:
> 
> "fatal: remote error: W access for foo/alice/a1 DENIED to bob"
> 
> If the git version is old and doesn't support this feature, then the
> message will be:
> 
> "fatal: invalid server response; got '# ERR W access for foo/alice/a1
> DENIED to bob'"

Yippee!  Thanks, Ilari.

For this specific error, why can't gitolite use an HTTP response code? Should http-backend be using ERR is some places, too, a la [1]?

Jonathan who would like to find time to write a test case for "git daemon" any day now

[1] http://thread.gmane.org/gmane.comp.version-control.git/145456/focus=145573