Re: [PATCH GSoC 1/3] gitweb: Create Gitweb::Config module

From: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
Date: Jun 3, 2010, 18:50 UTC
Message-ID: <AANLkTilnEtoZmi0GDmaUBk6cVLyLx8JhhEmldqFuhySM@mail.gmail.com>
In-Reply-To: <201006032043.14071.jnareb@gmail.com>

On Fri, Jun 4, 2010 at 12:13 AM, Jakub Narebski <jnareb@gmail.com> wrote:

Show 11 quoted lines

> Pavan Kumar Sunkara wrote:
>>
>> Even though it increases the patch size, I don't think it will be much
>> of a concern when it comes to good redability of code.
>>
>> Jakub: Can you reply, what you think about this argument ?
>
> But I agree that first, 'our $var' seems to imply that it is _new_
> variable declared in current scope, and second if we make a typo in
> variable name it wouldn't be detected as different from exported
> variable: 'our' will create new variable.

And it's hard to detect the typo while debugging.

Show 8 quoted lines

> So I agree that removing 'our' is a good idea, especially together
> with putting all variables that should be there in Gitweb::Config
> together with comments, even if they are configured during build
> process.
>
> Perhaps those declarations in Gitweb::Config should have in-line
> comment that they are defined in gitweb.cgi / gitweb.perl?
>

Yeah, Sure.

Thanks, Pavan.