Re: [PATCH GSoC 1/3] gitweb: Create Gitweb::Config module

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Jun 3, 2010, 17:04 UTC
Message-ID: <AANLkTikNzhIhrjbgF88EKf_FhJ6p_tzXHi0MaD-EMiLl@mail.gmail.com>
In-Reply-To: <201006031859.39278.jnareb@gmail.com>

On Thu, Jun 3, 2010 at 16:59, Jakub Narebski <jnareb@gmail.com> wrote:

Show 11 quoted lines

> Ævar Arnfjörð Bjarmason wrote:
>> On Thu, Jun 3, 2010 at 15:20, Petr Baudis <pasky@suse.cz> wrote:
>>> On Thu, Jun 03, 2010 at 07:25:54PM +0530, Pavan Kumar Sunkara wrote:
>>>>
>>>> +our @ISA = qw(Exporter);
>>
>> This is also re-arranging deck chairs on the Titanic, but 'use base
>> qw(Exporter)' is nicer.
>
> Or simply 'use Exporter qw(import);', as Perl 5.8+ supports
> 'use Module LIST' form.

Ah yes, if the code is lucky enough to require 5.8 in the first place. I didn't know whether gitweb was one of those things.