Re: [PATCH v3 03/13] add the basic data structure for line level history
- From
Bo Yang <struggleyb.nku@gmail.com>
- Date
- Jul 18, 2010, 14:35 UTC
- Message-ID
- <AANLkTilba9j1IfPbWuNUIxG-fkPjDIKAWubDneVJu4_N@mail.gmail.com>
- In-Reply-To
- <7vr5j8bq5x.fsf@alter.siamese.dyndns.org>
Hi Junio, On Tue, Jul 13, 2010 at 12:50 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 11 quoted lines
>> diff --git a/diffcore.h b/diffcore.h >> index 491bea0..13d8e93 100644 >> --- a/diffcore.h >> +++ b/diffcore.h >> @@ -23,6 +23,7 @@ >> #define MINIMUM_BREAK_SIZE 400 /* do not break a file smaller than this */ >> >> struct userdiff_driver; >> +struct diff_options; > > Why???
The line: extern void diffcore_rename(struct diff_options *); later in this file use it. So, forward declare it.
>>
...
Show 11 quoted lines
>> #define DECORATE_SHORT_REFS 1
>> #define DECORATE_FULL_REFS 2
>> @@ -68,7 +69,8 @@ struct rev_info {
>> cherry_pick:1,
>> bisect:1,
>> ancestry_path:1,
>> - first_parent_only:1;
>> + first_parent_only:1,
>> + line:1;
>
> Is this really a traversal flag that affects how the history is walked?Hmm, a 'line' means topologically traverse at least. So, I added it here. And I can't find a better place to put it. :)
I have changed my code according your comments, thanks a lot!
-- Regards! Bo ---------------------------- My blog: http://blog.morebits.org Why Git: http://www.whygitisbetterthanx.com/