Re: [PATCH v3 09/13] print the line log

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 12, 2010, 21:52 UTC
Message-ID: <7vsk3o8j1q.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1278829141-11900-9-git-send-email-struggleyb.nku@gmail.com>

Bo Yang <struggleyb.nku@gmail.com> writes:

Show 8 quoted lines

> +static void flush_lines(struct diff_options *opt, const char **ptr, const char *end,
> +		int slno, int elno, int *lno, const char *color, const char heading)
> +{
> +	const char *p = *ptr;
> +	struct strbuf buf = STRBUF_INIT;
> +	const char *reset;
> +
> +	if (strcmp(color, ""))

Did you mean "if (*color)"?

> +	/*
> +	 * todo: when --graph landed on master, this should be changed
> +	 * a little.
> +	 */

Hmm, don't we already have it?

> +static void diff_flush_filepair(struct rev_info *rev, struct diff_line_range *range)
> +{
> +...
> +}

Looks suspiciously familiar...  Cut-and-paste without refactoring?

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.