Re: [PATCH/RFC v8 0/2] Gettext support for Git

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Jun 5, 2010, 21:35 UTC
Message-ID: <AANLkTikvP6z4-AdbSJQYV5yo9UXKVh3lleFZ49_hmSZ5@mail.gmail.com>
In-Reply-To: <m3vd9xp3oz.fsf@localhost.localdomain>

On Sat, Jun 5, 2010 at 21:29, Jakub Narebski <jnareb@gmail.com> wrote:

Show 25 quoted lines

> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
>
>> This is version 8 of the series to make Git optionally translatable
>> with GNU gettext.
>>
>> Changes since version 7:
> [...]
>
>>    * Add back support (and a new test) for the no-op N_() macro. This
>>      is used for marking translations for later use, e.g.:
>>
>>         const char help[] =
>>               N_("See 'git help COMMAND' for more information on a specific command.");
>>
>>         int main(void)
>>         {
>>             puts(_(help));
>
> Shouldn't you add also corresponding N__ subroutine to Git::I18N
> module?
>
>  # Dummy functions for string marking.
>  sub N__($) {
>        return shift;
>  }

I don't really see the need. It's very useful in C because you can't call functions outside function bodies (like in the example above). Perl has no such restriction, so I don't see the use case.

Can you think of one? Perhaps I'm just being unimaginative.