From: Ævar Arnfjörð Bjarmason Date: Sat, 05 Jun 2010 21:35:29 GMT Subject: Re: [PATCH/RFC v8 0/2] Gettext support for Git Message-ID: In-Reply-To: On Sat, Jun 5, 2010 at 21:29, Jakub Narebski wrote: > Ævar Arnfjörð Bjarmason   writes: > >> This is version 8 of the series to make Git optionally translatable >> with GNU gettext. >> >> Changes since version 7: > [...] > >>    * Add back support (and a new test) for the no-op N_() macro. This >>      is used for marking translations for later use, e.g.: >> >>         const char help[] = >>               N_("See 'git help COMMAND' for more information on a specific command."); >> >>         int main(void) >>         { >>             puts(_(help)); > > Shouldn't you add also corresponding N__ subroutine to Git::I18N > module? > >  # Dummy functions for string marking. >  sub N__($) { >        return shift; >  } I don't really see the need. It's very useful in C because you can't call functions outside function bodies (like in the example above). Perl has no such restriction, so I don't see the use case. Can you think of one? Perhaps I'm just being unimaginative.