Re: [PATCH] grep: Don't pass a TODO test if REG_STARTEND is supported

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Jul 8, 2010, 20:09 UTC
Message-ID: <AANLkTikuGY4LVrCB6UoGFhxthoI8MgvAXCwCbiXhwq_d@mail.gmail.com>
In-Reply-To: <7viq4ppxt9.fsf@alter.siamese.dyndns.org>

On Thu, Jul 8, 2010 at 19:40, Junio C Hamano <gitster@pobox.com> wrote:

Show 13 quoted lines

> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
>
>> +if git grep ile a
>> +then
>> +     test_expect_success 'git grep ile a' 'git grep ile a'
>> +else
>> +     test_expect_failure 'git grep ile a' 'git grep ile a'
>> +fi
>
> So if command "X" is known to succeed, we run it inside expect_success
> and if not we run it inside expect_failure?
>
> What kind of idiocy is that, I have to wonder...

Well, the point is to normalize the test suite so that we never have passing TODO tests if everything's OK.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.