From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Thu, 08 Jul 2010 20:09:17 GMT
Subject: Re: [PATCH] grep: Don't pass a TODO test if REG_STARTEND is supported
Message-ID: <AANLkTikuGY4LVrCB6UoGFhxthoI8MgvAXCwCbiXhwq_d@mail.gmail.com>
In-Reply-To: <7viq4ppxt9.fsf@alter.siamese.dyndns.org>

On Thu, Jul 8, 2010 at 19:40, Junio C Hamano <gitster@pobox.com> wrote:
> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
>
>> +if git grep ile a
>> +then
>> +     test_expect_success 'git grep ile a' 'git grep ile a'
>> +else
>> +     test_expect_failure 'git grep ile a' 'git grep ile a'
>> +fi
>
> So if command "X" is known to succeed, we run it inside expect_success
> and if not we run it inside expect_failure?
>
> What kind of idiocy is that, I have to wonder...

Well, the point is to normalize the test suite so that we never have
passing TODO tests if everything's OK.