git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC 00/17] Begin gettextizing Git

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Aug 31, 2010, 18:24 UTC
Message-ID
<AANLkTikk8nVyvp0hTycMY9bjMub38msxrOHMMLNER_DS@mail.gmail.com>
In-Reply-To
<20100831180832.GQ2315@burratino>
On Tue, Aug 31, 2010 at 18:08, Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 8 quoted lines
> Ævar Arnfjörð Bjarmason wrote:
>
>> Or: git://github.com/avar/git.git gettextize-git-mainporcelain-v2
>
> Is that against "next"?  For an RFC that's okay, but for a series
> that will be part of a release it can be tedious to separate out
> (not all topics in "next" necessarily are released, and "next"
> traditionally gets rewound after each release).

Yes it's against next since it had the gettext series merged and next is about to be released isn't it? I could base it on something else if that's appropriate.

Show 9 quoted lines
> Comments on the patches:
>
>  Makefile: use variables and shorter lines for xgettext
>
> The -o<whatever> passed to cc isn't usually included in CFLAGS,
> and a part of me is similarly uncomfortable with including it in
> XGETTEXT_OPTIONS.  Isn't that parameter something that should be
> possible to change in the build system independently from the
> user's XGETTEXT_OPTIONS preferences?

Maybe, but it'll always be --output=po/git.pot so I saw no reason to seperate it. Should it be? The -o for the C compiler changes, but the "make pot" target will always write to po/git.pot.

>  gettext.c: work around us not using setlocale(LC_CTYPE, "")
>
> The perror() problem shows up with strerror(), too, of course.
> (perror just made for an easier demo.)
Yeah, and everything external like that, unfortunately.
Show 9 quoted lines
>  gettext: Make NO_GETTEXT=YesPlease the default in releases
>
> Copy-edits for the notes in INSTALL:
>
>> +       - Git includes EXPERIMENTAL support for localization with gettext
>> +         which is currently disabled by default in official Git
>> +         releases.
>
> s/EXPERIMENTAL/experimental/?  No need to shout.
OKEY THEN!
> I'd also s/currently // since this will not be current after a while.
ok.
Show 7 quoted lines
>> +         If you really want to build it you have to specify NO_GETTEXT=
>> +         as a Makefile argument. If you're a downstream distributor
>> +         please don't do so without consulting with the Git Mailing List
>> +         first about the stability of this feature.
>
> Similarly I'd s/really //.  If we want to dissuade people from trying
> it out, we should probably do that with more explicit statements.
Thanks.
Show 10 quoted lines
>> +         It's only being included in releases so that source messages can
>> +         be marked for translation without resulting in painful and
>> +         inevitable merge conflicts between Git's pu branch and the
>> +         rest. END WARNING.
>
> Not sure what this means.  Maybe:
>
>  The infrastructure is only included in this release to avoid
>  complications in building other work on top of it.  If you turn
>  it on, expect breakage.

Yes, that's better. I've worked all these into a gettextize-git-mainporcelain-v3 branch at the same repository:

    http://github.com/avar/git/compare/gettextize-git-mainporcelain-v2...gettextize-git-mainporcelain-v3
Or: git://github.com/avar/git.git gettextize-git-mainporcelain-v3
Previous: Jonathan NiederNext: Jonathan Nieder
Message 45 of 55 in “Begin gettextizing Git”
  1. 00/17 Begin gettextizing GitÆvar Arnfjörð Bjarmason, Aug 30, 2010
  2. 01/17 Makefile: A variable for options used by xgettext(1) callsÆvar Arnfjörð Bjarmason, Aug 30, 2010
  3. Jonathan NiederAug 31, 2010
  4. Ævar Arnfjörð BjarmasonAug 31, 2010
  5. 02/17 Makefile: provide a --msgid-bugs-address to xgettext(1)Ævar Arnfjörð Bjarmason, Aug 30, 2010
  6. 03/17 Makefile: tell xgettext(1) that our source is in UTF-8Ævar Arnfjörð Bjarmason, Aug 30, 2010
  7. 04/17 builtin.h: Include gettext.hÆvar Arnfjörð Bjarmason, Aug 30, 2010
  8. 05/17 gettext: make the simple parts of git-init localizableÆvar Arnfjörð Bjarmason, Aug 30, 2010
  9. Jonathan NiederAug 31, 2010
  10. Ævar Arnfjörð BjarmasonAug 31, 2010
  11. Jonathan NiederAug 31, 2010
  12. Ævar Arnfjörð BjarmasonAug 31, 2010
  13. Jonathan NiederAug 31, 2010
  14. Junio C HamanoAug 31, 2010
  15. 06/17 gettext: localize the main git-init messageÆvar Arnfjörð Bjarmason, Aug 30, 2010
  16. Jonathan NiederAug 31, 2010
  17. Ævar Arnfjörð BjarmasonAug 31, 2010
  18. Jonathan NiederAug 31, 2010
  19. 07/17 gettext.c: work around us not using setlocale(LC_CTYPE, "")Ævar Arnfjörð Bjarmason, Aug 30, 2010
  20. Jonathan NiederAug 31, 2010
  21. Marcin CieslakAug 31, 2010
  22. Jonathan NiederAug 31, 2010
  23. Ævar Arnfjörð BjarmasonAug 31, 2010
  24. Jonathan NiederAug 31, 2010
  25. Erik Faye-LundAug 31, 2010
  26. 08/17 gettext tests: test if $VERSION exists before using itÆvar Arnfjörð Bjarmason, Aug 30, 2010
  27. 09/17 gettext tests: update test/is.po to match t/t0200/test.cÆvar Arnfjörð Bjarmason, Aug 30, 2010
  28. 10/17 gettext tests: add detection for is_IS.ISO-8859-1 localeÆvar Arnfjörð Bjarmason, Aug 30, 2010
  29. 11/17 gettext tests: test message re-encoding under ShellÆvar Arnfjörð Bjarmason, Aug 30, 2010
  30. 12/17 gettext tests: test re-encoding with a UTF-8 msgid under ShellÆvar Arnfjörð Bjarmason, Aug 30, 2010
  31. 13/17 gettext tests: mark a test message as not needing translationÆvar Arnfjörð Bjarmason, Aug 30, 2010
  32. 14/17 po/is.po: msgmerge and add Language: headerÆvar Arnfjörð Bjarmason, Aug 30, 2010
  33. 15/17 po/is.po: add Icelandic translationÆvar Arnfjörð Bjarmason, Aug 30, 2010
  34. Jonathan NiederAug 31, 2010
  35. Ævar Arnfjörð BjarmasonAug 31, 2010
  36. Erik Faye-LundAug 31, 2010
  37. Ævar Arnfjörð BjarmasonAug 31, 2010
  38. Erik Faye-LundAug 31, 2010
  39. 16/17 po/pl.po: add Polish translationÆvar Arnfjörð Bjarmason, Aug 30, 2010
  40. 17/17 gettext tests: test message re-encoding under CÆvar Arnfjörð Bjarmason, Aug 30, 2010
  41. Junio C HamanoAug 30, 2010
  42. gettext: Make NO_GETTEXT=YesPlease the default in releasesÆvar Arnfjörð Bjarmason, Aug 31, 2010
  43. Ævar Arnfjörð BjarmasonAug 31, 2010
  44. Jonathan NiederAug 31, 2010
  45. Ævar Arnfjörð BjarmasonAug 31, 2010
  46. Jonathan NiederAug 31, 2010
  47. Ævar Arnfjörð BjarmasonAug 31, 2010
  48. Jonathan NiederAug 31, 2010
  49. Peter KreftingAug 31, 2010
  50. Ævar Arnfjörð BjarmasonAug 31, 2010
  51. Peter KreftingAug 31, 2010
  52. Matthieu MoyAug 31, 2010
  53. Ævar Arnfjörð BjarmasonAug 31, 2010
  54. Jonathan NiederAug 31, 2010
  55. Ævar Arnfjörð BjarmasonAug 31, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.