Re: [PATCH/RFC 00/17] Begin gettextizing Git

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 30, 2010, 21:42 UTC
Message-ID: <7v39tveq0j.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1283203703-26923-1-git-send-email-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

Show 15 quoted lines

> Now that Git has the infrastructure for translation in next I'm going
> to start submitting patches to make the main porcelain translatable.
>
> This series starts that work, and fixes and also fixes up some of the
> infrastructure (like the bug discussed in "Odd encoding issue with
> UTF-8 + gettext yields ? on non-ASCII"), and adds tests to make sure
> it's all working.
>
> With it applied git-init is the one and only utility of the porcelain
> that's translatable. The series includes a translation of it into
> Icelandic and Polish.
>
> I think it's ready to be applied. I tested it on Solaris, FreeBSD and
> Debian. But there's almost definitely something I'm missing in a
> series this big, so it's an RFC.

Thanks; will queue them.

I however strongly suspect that we would be better off first kicking the earlier parts of i18n topic out of 'next' back to 'pu', as I am hoping that we can declare feature freeze for 1.7.3 by the end of this week at the latest, and you can never tell if we got the "infrastructure" right without playing with a real "user of the infrastructure" like this 17 patch series, which means that the part of i18n topic that is already in 'next' cannot be part of 1.7.3 --- it is way premature.

It was somewhat unfortunate and sad that your "test" series depended on a few patches from the i18n series, which means it is now taken hostage to the latter. I'd rather want to have the "test" series in the 1.7.3, and we need to think about a way to untangle the two topics.