git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix potential local deadlock during fetch-pack

From
Shawn Pearce <spearce@spearce.org>
Date
Mar 31, 2011, 16:24 UTC
Message-ID
<AANLkTiki2__qAqgDnB6yu8kzxNW-bMj2qJcx50yawCWM@mail.gmail.com>
In-Reply-To
<AANLkTikCRRftjExdhMgFGFMy-Dc1UCMdW1nTYV2bK1-T@mail.gmail.com>
On Wed, Mar 30, 2011 at 02:42, Erik Faye-Lund <kusmabite@gmail.com> wrote:
Show 10 quoted lines
> On Tue, Mar 29, 2011 at 7:06 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> The fetch-pack/upload-pack protocol relies on the underlying transport
>> (local pipe or TCP socket) to have enough slack to allow one window worth
>> of data in flight without blocking the writer.  Traditionally we always
>> relied on being able to have a batch of 32 "have"s in flight (roughly 1.5k
>> bytes) to stream.
>
> Hmm, this explanation makes me wonder: Could this be related to the
> deadlock we're experiencing with git-push over the git-protocol on
> Windows when side-band-64k is enabled?

I think its unrelated. It might also be a deadlock, but the push protocol is quite a bit different. As far as I remember, there is no risk of deadlock in the push protocol.

-- 
Shawn.
Previous: Erik Faye-Lund
Message 6 of 6 in “Fix potential local deadlock during fetch-pack”
  1. Fix potential local deadlock during fetch-packJunio C Hamano, Mar 29, 2011
  2. Shawn PearceMar 29, 2011
  3. Shawn PearceMar 29, 2011
  4. Erik Faye-LundMar 30, 2011
  5. Erik Faye-LundMar 30, 2011
  6. Shawn PearceMar 31, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.