Re: jn/apply-filename-with-sp (Re: What's cooking in git.git (Aug 2010, #02; Wed, 11))

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Aug 12, 2010, 22:46 UTC
Message-ID: <AANLkTikZY8-QaBZbZauoTKDnMxp6D9bS+Av4uSVTwOT5@mail.gmail.com>
In-Reply-To: <20100812224044.GK2029@burratino>

On Thu, Aug 12, 2010 at 22:40, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 15 quoted lines

> Johannes Sixt wrote:
>> Am 8/12/2010 1:35, schrieb Junio C Hamano:
>
>>> * jn/apply-filename-with-sp (2010-07-23) 4 commits
>>>  - apply: Handle traditional patches with space in filename
>>>  - t4135 (apply): use expand instead of pr for portability
>>>  - tests: Test how well "git apply" copes with weird filenames
>>>  - apply: Split quoted filename handling into new function
>>>
>>> Looked Ok.  Will merge to 'next'.
>>
>> The test cases that work with files with tabs must have a prerequisite;
>> see t3600-rm.sh.
>
> Would this work?

This is nice, but incomplete. I just recently added a bunch of TABS_IN_FILENAMES prereqs to pu, moving that prereq setup to test-lib.sh + making the rm test use it would be better, we might want more specific name restrictions than just "funny".

Please also add docs for the new prereq to t/README. There's a new section for those now too.

Thanks.