Re: What's cooking in git.git (Aug 2010, #02; Wed, 11)
- From
Greg Brockman <gdb@mit.edu>
- Date
- Aug 12, 2010, 22:13 UTC
- Message-ID
- <AANLkTi=Pcn_mwr=5Znr5a3KvN4BAPpqUjro45Lfj7WGF@mail.gmail.com>
- In-Reply-To
- <7v62zfqya9.fsf@alter.siamese.dyndns.org>
My apologies... I'm still trying to figure out my way around the conventions around here, and hadn't intended that as an indicator to not pick up the patch. I'll submit a revised version using expanduser("~").
Greg
On Thu, Aug 12, 2010 at 6:08 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 22 quoted lines
> Greg Brockman <gdb@MIT.EDU> writes:
>
>>>> * gb/shell-ext (2010-07-28) 3 commits
>>>> - Add sample commands for git-shell
>>>> - Add interactive mode to git-shell for user-friendliness
>>>> - Allow creation of arbitrary git-shell commands
>>>
>>> This needs work on Windows because we do not have geteuid(), perhaps just
>>> a compiler flag -Dgeteuid=getuid
>> I had a submitted a revised patch that just uses HOME, see
>> http://thread.gmane.org/gmane.comp.version-control.git/152050/focus=152135.
>> I guess that didn't make it in yet.
>
> No, it didn't; because you said
>
> Err, actually it would probably be a good idea to
> s/char *home = getenv("HOME");/const char *home = getenv("HOME");/
>
> Greg
>
> hinting me not to pick it up.
>