Re: [PATCH 9/9] commit: suppress status summary when no changes staged
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Aug 12, 2010, 00:05 UTC
- Message-ID
- <AANLkTikVyWjTmRssQyBfRVY=PLguTgHHA+_YdsmsMwP3@mail.gmail.com>
- In-Reply-To
- <20100811235742.GA18499@burratino>
On Wed, Aug 11, 2010 at 23:57, Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 7 quoted lines
> Ævar Arnfjörð Bjarmason wrote: >> On Wed, Aug 11, 2010 at 07:30, Jonathan Nieder <jrnieder@gmail.com> wrote: > >>> -test_expect_success 'status' ' >>> +test_expect_failure 'status' ' > > Oops. Did you see the follow-up patch?
No, I'm probably missing something. Move along now, nothing to see here :)
Show 11 quoted lines
>> Better to test_expect_success like my patch does and explicitly check >> the output, otherwise that test will pass if any part of it fails, >> e.g. if the checkout fails. >> >> Not likely, but it's more likely that the output will change again, in >> which case the grep tests I did would start failing again. > > The wt-status output series ought have included a separate test for > the new “git commit --dry-run” output. But this is not what that test > script is about, and I think including it there would have been > confusing.
Sounds like you got this covered, that's good enough for me.
> Sorry for the breakage, and thanks for reporting it.
No problem.