git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] tests: fix syntax error in "Use advise() for hints" test

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Aug 19, 2010, 12:22 UTC
Message-ID
<AANLkTikDq4eJfm2RnbGDuJMHCR8_4cn6NfJpoYWHbWWN@mail.gmail.com>
In-Reply-To
<20100819043036.GD25649@burratino>
On Thu, Aug 19, 2010 at 04:30, Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 6 quoted lines
> Ævar Arnfjörð Bjarmason wrote:
>
>> Change the test introduced in the "Use advise() for hints" patch by
>> Jonathan Nieder not to use '' for quotes inside '' delimited code.
>
> Yikes.  Thanks for catching this.
FWIW prove flagged it:
    $ prove ./t35*.sh
    ./t3500-cherry.sh .................... ok
    ./t3501-revert-cherry-pick.sh ........ ok
    ./t3502-cherry-pick-merge.sh ......... ok
    ./t3503-cherry-pick-root.sh .......... ok
    ./t3504-cherry-pick-rerere.sh ........ ok
    ./t3505-cherry-pick-empty.sh ......... ok
    ./t3506-cherry-pick-ff.sh ............ ok
    ./t3507-cherry-pick-conflict.sh ...... 1/?
./t3507-cherry-pick-conflict.sh: 59: cannot open paths: No such file
    ./t3507-cherry-pick-conflict.sh ...... ok
    ./t3508-cherry-pick-many-commits.sh .. ok
    ./t3509-cherry-pick-merge-df.sh ...... ok
    All tests successful.
    Files=10, Tests=62,  4 wallclock secs ( 0.08 usr  0.06 sys +  0.65
cusr  2.91 csys =  3.70 CPU)
    Result: PASS
> Although the style you chose is arguably the least ugly, nested shell
> interpolation can be hard to follow.  How about this?

I think '\'' is harder to follow than \" and \$, but each to his own :)

Previous: Jonathan NiederNext: Raja R Harinath
Message 35 of 38 in “commit: more focused advice in the no-changes-staged case”
  1. 0/9 commit: more focused advice in the no-changes-staged caseJonathan Nieder, Jul 25, 2010
  2. 1/9 wt-status: split wt_status_print into digestible piecesJonathan Nieder, Jul 25, 2010
  3. 2/9 wt-status: split off a function for printing submodule summaryJonathan Nieder, Jul 25, 2010
  4. 3/9 commit: split off a function to fetch the default log messageJonathan Nieder, Jul 25, 2010
  5. 4/9 commit: split commit -s handling into its own functionJonathan Nieder, Jul 25, 2010
  6. 5/9 commit: split off the piece that writes statusJonathan Nieder, Jul 25, 2010
  7. 6/9 t7508 (status): modernize styleJonathan Nieder, Jul 25, 2010
  8. Ævar Arnfjörð BjarmasonJul 25, 2010
  9. 7/9 commit: give empty-commit avoidance code its own functionJonathan Nieder, Jul 25, 2010
  10. 8/9 commit --dry-run: give advice on empty amendJonathan Nieder, Jul 25, 2010
  11. 9/9 commit: suppress status summary when no changes stagedJonathan Nieder, Jul 25, 2010
  12. Thomas RastAug 11, 2010
  13. Jonathan NiederAug 11, 2010
  14. t6040 (branch tracking): check “status” instead of “commit”Jonathan Nieder, Aug 11, 2010
  15. Ævar Arnfjörð BjarmasonAug 12, 2010
  16. Ævar Arnfjörð BjarmasonAug 11, 2010
  17. Jonathan NiederAug 11, 2010
  18. Ævar Arnfjörð BjarmasonAug 12, 2010
  19. Jonathan NiederAug 12, 2010
  20. Ævar Arnfjörð BjarmasonJul 25, 2010
  21. Thomas RastJul 25, 2010
  22. Making error messages stand out (Re: [RFC/PATCH 0/9] commit: more focused advice in the no-changes-staged case)Jonathan Nieder, Jul 29, 2010
  23. Sverre RabbelierJul 30, 2010
  24. 0/4 Re: Making error messages stand outJonathan Nieder, Aug 11, 2010
  25. 1/4 Eliminate “Finished cherry-pick/revert” messageJonathan Nieder, Aug 11, 2010
  26. 2/4 Introduce advise() to print hintsJonathan Nieder, Aug 11, 2010
  27. 3/4 cherry-pick/revert: Use error() for failure messageJonathan Nieder, Aug 11, 2010
  28. 4/4 cherry-pick/revert: Use advise() for hintsJonathan Nieder, Aug 11, 2010
  29. Nguyen Thai Ngoc DuyAug 11, 2010
  30. Matthieu MoyAug 11, 2010
  31. Nguyen Thai Ngoc DuyAug 11, 2010
  32. Sverre RabbelierAug 11, 2010
  33. tests: fix syntax error in "Use advise() for hints" testÆvar Arnfjörð Bjarmason, Aug 18, 2010
  34. Jonathan NiederAug 19, 2010
  35. Ævar Arnfjörð BjarmasonAug 19, 2010
  36. Raja R HarinathAug 20, 2010
  37. Ævar Arnfjörð BjarmasonAug 20, 2010
  38. Junio C HamanoAug 20, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.