Re: [PATCH] Make commit help text more accurate for --verbose

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sep 5, 2010, 16:30 UTC
Message-ID: <AANLkTikLTykbgUjCK4H0cbF0QXZHOPYbLdptEKe4-rD5@mail.gmail.com>
In-Reply-To: <AANLkTinEZ92S_XB4zrnb26eVR-MFsDQcSPAZ3RXj6ofH@mail.gmail.com>

On Sun, Sep 5, 2010 at 15:06, Thiago Farina <tfransosi@gmail.com> wrote:

Show 19 quoted lines

> Hi Ramana,
>
> Some *style* comments below.
> On Sun, Sep 5, 2010 at 6:53 AM, Ramana Kumar <ramana.kumar@gmail.com> wrote:
>>                fprintf(fp,
>>                        "\n"
>>                        "# Please enter the commit message for your changes.");
>> -               if (cleanup_mode == CLEANUP_ALL)
>> +               if (cleanup_mode == CLEANUP_ALL && !verbose)
>>                        fprintf(fp,
>>                                " Lines starting\n"
>>                                "# with '#' will be ignored, and an empty"
>>                                " message aborts the commit.\n");
> The Documentation/CodingStyle says to avoid using braces unncessary.
> But since this is not a single line statement, like:
> if (foo)
>  foo = x;
>
> Could you wrapp this into { } ?

The braces are still unncessary if the function call is spread across a few lines. I haven't seen anything in the source that indicates that we prefer braces when a braceless if/else has an associated statement that exceeds 1 line.