threads / patch / 24982

patchMake commit help text more accurate for --verbose

Subject: [PATCH] Make commit help text more accurate for --verbose

## tl;dr

4 messages between Sep 5, 2010 and Sep 14, 2010. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Ramana Kumar· Sep 5, 2010, 09:53 UTC · lore

Commit message help text says lines starting with '#' will be ignored. The diff lines added by --verbose are also ignored, although they don't start with '#'s. Extend help text to describe behavior on diff lines when relevant.

Signed-off-by: Ramana Kumar <ramana.kumar@gmail.com>
---
 builtin/commit.c |   25 ++++++++++++++++++-------
 1 files changed, 18 insertions(+), 7 deletions(-)

Show changes to builtin/commit.c +18 −7

diff --git a/builtin/commit.c b/builtin/commit.c
index 66fdd22..b49fd7a 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -658,17 +658,28 @@ static int prepare_to_commit(const char *index_file, const char *prefix,
 		fprintf(fp,
 			"\n"
 			"# Please enter the commit message for your changes.");
-		if (cleanup_mode == CLEANUP_ALL)
+		if (cleanup_mode == CLEANUP_ALL && !verbose)
 			fprintf(fp,
 				" Lines starting\n"
 				"# with '#' will be ignored, and an empty"
 				" message aborts the commit.\n");
-		else /* CLEANUP_SPACE, that is. */
-			fprintf(fp,
-				" Lines starting\n"
-				"# with '#' will be kept; you may remove them"
-				" yourself if you want to.\n"
-				"# An empty message aborts the commit.\n");
+    else {
+      if (cleanup_mode == CLEANUP_ALL)
+        fprintf(fp,
+          " Lines starting\n"
+          "# with '#' will be ignored, as will"
+          " the diff and anything below it.\n");
+      else { /* CLEANUP_SPACE, that is. */
+        fprintf(fp,
+          " Lines starting\n"
+          "# with '#' will be kept; you may remove them"
+          " yourself if you want to.\n");
+        if (verbose)
+          fprintf(fp,
+            "# The diff and anything below it will be ignored.\n");
+      }
+      fprintf(fp, "# An empty message aborts the commit.\n");
+    }
 		if (only_include_assumed)
 			fprintf(fp, "# %s\n", only_include_assumed);

-- 
1.7.2.2

Thiago Farina· Sep 5, 2010, 15:06 UTC · re: Ramana Kumar · lore

Re: [PATCH] Make commit help text more accurate for --verbose

Hi Ramana,

Some *style* comments below. On Sun, Sep 5, 2010 at 6:53 AM, Ramana Kumar <ramana.kumar@gmail.com> wrote:

Show 9 quoted lines

>                fprintf(fp,
>                        "\n"
>                        "# Please enter the commit message for your changes.");
> -               if (cleanup_mode == CLEANUP_ALL)
> +               if (cleanup_mode == CLEANUP_ALL && !verbose)
>                        fprintf(fp,
>                                " Lines starting\n"
>                                "# with '#' will be ignored, and an empty"
>                                " message aborts the commit.\n");

The Documentation/CodingStyle says to avoid using braces unncessary.
But since this is not a single line statement, like:
if (foo)
  foo = x;

Could you wrapp this into { } ?

Show 12 quoted lines

> -               else /* CLEANUP_SPACE, that is. */
> -                       fprintf(fp,
> -                               " Lines starting\n"
> -                               "# with '#' will be kept; you may remove them"
> -                               " yourself if you want to.\n"
> -                               "# An empty message aborts the commit.\n");
> +    else {
> +      if (cleanup_mode == CLEANUP_ALL)
> +        fprintf(fp,
> +          " Lines starting\n"
> +          "# with '#' will be ignored, as will"
> +          " the diff and anything below it.\n");

Same thing here (and below) as pointed above.

Show 14 quoted lines

> +      else { /* CLEANUP_SPACE, that is. */
> +        fprintf(fp,
> +          " Lines starting\n"
> +          "# with '#' will be kept; you may remove them"
> +          " yourself if you want to.\n");
> +        if (verbose)
> +          fprintf(fp,
> +            "# The diff and anything below it will be ignored.\n");
> +      }
> +      fprintf(fp, "# An empty message aborts the commit.\n");
> +    }
>                if (only_include_assumed)
>                        fprintf(fp, "# %s\n", only_include_assumed);
>

Ævar Arnfjörð Bjarmason· Sep 5, 2010, 16:30 UTC · re: Thiago Farina · lore

Re: [PATCH] Make commit help text more accurate for --verbose

On Sun, Sep 5, 2010 at 15:06, Thiago Farina <tfransosi@gmail.com> wrote:

Show 19 quoted lines

> Hi Ramana,
>
> Some *style* comments below.
> On Sun, Sep 5, 2010 at 6:53 AM, Ramana Kumar <ramana.kumar@gmail.com> wrote:
>>                fprintf(fp,
>>                        "\n"
>>                        "# Please enter the commit message for your changes.");
>> -               if (cleanup_mode == CLEANUP_ALL)
>> +               if (cleanup_mode == CLEANUP_ALL && !verbose)
>>                        fprintf(fp,
>>                                " Lines starting\n"
>>                                "# with '#' will be ignored, and an empty"
>>                                " message aborts the commit.\n");
> The Documentation/CodingStyle says to avoid using braces unncessary.
> But since this is not a single line statement, like:
> if (foo)
>  foo = x;
>
> Could you wrapp this into { } ?

The braces are still unncessary if the function call is spread across a few lines. I haven't seen anything in the source that indicates that we prefer braces when a braceless if/else has an associated statement that exceeds 1 line.

Ramana Kumar· Sep 14, 2010, 09:08 UTC · re: Ævar Arnfjörð Bjarmason · lore

Re: [PATCH] Make commit help text more accurate for --verbose

On Mon, Sep 6, 2010 at 2:30 AM, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 25 quoted lines

> On Sun, Sep 5, 2010 at 15:06, Thiago Farina <tfransosi@gmail.com> wrote:
>> Hi Ramana,
>>
>> Some *style* comments below.
>> On Sun, Sep 5, 2010 at 6:53 AM, Ramana Kumar <ramana.kumar@gmail.com> wrote:
>>>                fprintf(fp,
>>>                        "\n"
>>>                        "# Please enter the commit message for your changes.");
>>> -               if (cleanup_mode == CLEANUP_ALL)
>>> +               if (cleanup_mode == CLEANUP_ALL && !verbose)
>>>                        fprintf(fp,
>>>                                " Lines starting\n"
>>>                                "# with '#' will be ignored, and an empty"
>>>                                " message aborts the commit.\n");
>> The Documentation/CodingStyle says to avoid using braces unncessary.
>> But since this is not a single line statement, like:
>> if (foo)
>>  foo = x;
>>
>> Could you wrapp this into { } ?
>
> The braces are still unncessary if the function call is spread across
> a few lines. I haven't seen anything in the source that indicates that
> we prefer braces when a braceless if/else has an associated statement
> that exceeds 1 line.

Any other suggestions to improve this patch?