Re: [PATCH 07/15] daemon: use run-command api for async serving

From: Erik Faye-Lund <kusmabite@gmail.com>
Date: Oct 22, 2010, 00:20 UTC
Message-ID: <AANLkTikL-uWKUtcB=NS+42ajAGrLH1B9CEE6B-0Ykeiq@mail.gmail.com>
In-Reply-To: <20101022001010.GB13779@burratino>

On Fri, Oct 22, 2010 at 2:10 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 16 quoted lines

> Erik Faye-Lund wrote:
>
>> --- a/daemon.c
>> +++ b/daemon.c
> [...]
>> @@ -671,18 +658,26 @@ static void check_dead_children(void)
>>       int status;
>>       pid_t pid;
>>
>> -     while ((pid = waitpid(-1, &status, WNOHANG)) > 0) {
>> +     struct child **cradle, *blanket;
>> +     for (cradle = &firstborn; (blanket = *cradle);)
>> +             if ((pid = waitpid(blanket->cld.pid, &status, WNOHANG)) > 1) {
>
> What is this change (> 0 → > 1) about?
>

Oooh, that's a typo, nice catch! I'll throw in a hot-fix when reposting!