git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 13/15] daemon: use socklen_t

From
Erik Faye-Lund <kusmabite@gmail.com>
Date
Oct 22, 2010, 00:05 UTC
Message-ID
<1287705944-5668-13-git-send-email-kusmabite@gmail.com>
In-Reply-To
<1287705944-5668-1-git-send-email-kusmabite@gmail.com>

Windows's accept()-function takes the last argument as an int, but glibc takes an unsigned int. Use socklen_t to get rid of a warning. This is basically a revert of 7fa0908, but we have already been depending on socklen_t existing since June 2006 (commit 5b276ee4). I guess this means that socklen_t IS defined on OSX after all - at least in recent headers.

Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
---
 daemon.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/daemon.c b/daemon.c
index 19b4eb3..af13f4a 100644
--- a/daemon.c
+++ b/daemon.c
@@ -597,7 +597,7 @@ static struct child {
 	struct sockaddr_storage address;
 } *firstborn;
 
-static void add_child(struct child_process *cld, struct sockaddr *addr, int addrlen)
+static void add_child(struct child_process *cld, struct sockaddr *addr, socklen_t addrlen)
 {
 	struct child *newborn, **cradle;
 
@@ -654,7 +654,7 @@ static void check_dead_children(void)
 }
 
 static char **cld_argv;
-static void handle(int incoming, struct sockaddr *addr, int addrlen)
+static void handle(int incoming, struct sockaddr *addr, socklen_t addrlen)
 {
 	struct child_process cld = { 0 };
 	char addrbuf[300] = "REMOTE_ADDR=", portbuf[300];
@@ -904,7 +904,7 @@ static int service_loop(struct socketlist *socklist)
 		for (i = 0; i < socklist->nr; i++) {
 			if (pfd[i].revents & POLLIN) {
 				struct sockaddr_storage ss;
-				unsigned int sslen = sizeof(ss);
+				socklen_t sslen = sizeof(ss);
 				int incoming = accept(pfd[i].fd, (struct sockaddr *)&ss, &sslen);
 				if (incoming < 0) {
 					switch (errno) {
-- 
1.7.3.1.199.g72340
Previous: Erik Faye-LundNext: Erik Faye-Lund
Message 15 of 18 in “mingw: implement syslog”
  1. 01/15 mingw: implement syslogErik Faye-Lund, Oct 22, 2010
  2. 02/15 compat: add inet_pton and inet_ntop prototypesErik Faye-Lund, Oct 22, 2010
  3. 03/15 inet_ntop: fix a couple of old-style declsErik Faye-Lund, Oct 22, 2010
  4. 04/15 mingw: use real pidErik Faye-Lund, Oct 22, 2010
  5. 05/15 mingw: support waitpid with pid > 0 and WNOHANGErik Faye-Lund, Oct 22, 2010
  6. 06/15 mingw: add kill emulationErik Faye-Lund, Oct 22, 2010
  7. 07/15 daemon: use run-command api for async servingErik Faye-Lund, Oct 22, 2010
  8. Jonathan NiederOct 22, 2010
  9. Erik Faye-LundOct 22, 2010
  10. 08/15 daemon: use full buffered mode for stderrErik Faye-Lund, Oct 22, 2010
  11. 09/15 Improve the mingw getaddrinfo stub to handle more use casesErik Faye-Lund, Oct 22, 2010
  12. 10/15 daemon: get remote host address from root-processErik Faye-Lund, Oct 22, 2010
  13. 11/15 mingw: import poll-emulation from gnulibErik Faye-Lund, Oct 22, 2010
  14. 12/15 mingw: use poll-emulation from gnulibErik Faye-Lund, Oct 22, 2010
  15. 13/15 daemon: use socklen_tErik Faye-Lund, Oct 22, 2010
  16. 14/15 daemon: make --inetd and --detcach incompatibleErik Faye-Lund, Oct 22, 2010
  17. 15/15 daemon: opt-out on features that require posixErik Faye-Lund, Oct 22, 2010
  18. Erik Faye-LundOct 22, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.