Re: [PATCH 1/3] Move libgit.a sources into a libgit/ subdirectory
- From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
- Date
- Feb 18, 2011, 03:47 UTC
- Message-ID
- <AANLkTikFLkXKKhZoDGAgh+i8H2fv+QNEVj7vEVABxee2@mail.gmail.com>
- In-Reply-To
- <20110218023126.GB23435@elie>
2011/2/18 Jonathan Nieder <jrnieder@gmail.com>:
> Move sources for libgit.a to a libgit/ subdirectory. This way, a > person wanting to tackle the reusable part of git will know where to > look, and those looking to work on individual commands know to look > elsewhere.
You missed a few (on purpose?): block-sha1, ppc and compat.
libgit.a is produced at toplevel so I need a few more keystrokes to reach files inside libgit. Maybe move libgit.a to libgit too?
> Perhaps some day the libgit/ subdirectory can be managed as an > independent subproject (for example if it gets merged with libgit2).
With die() all over the place in libgit.a, I doubt it would become an independent project. Although this certainly makes it easier to reimplement libgit as a thin wrapper around libgit2.
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
-- Duy