Re: [PATCH 1/3] Move libgit.a sources into a libgit/ subdirectory
- From
Jeff King <peff@peff.net>
- Date
- Feb 18, 2011, 04:18 UTC
- Message-ID
- <20110218041840.GB12348@sigill.intra.peff.net>
- In-Reply-To
- <20110218041358.GB15643@elie>
On Thu, Feb 17, 2011 at 10:14:05PM -0600, Jonathan Nieder wrote:
Show 11 quoted lines
> Nguyen Thai Ngoc Duy wrote: > > 2011/2/18 Jonathan Nieder <jrnieder@gmail.com>: > > >> Move sources for libgit.a to a libgit/ subdirectory. This way, a > >> person wanting to tackle the reusable part of git will know where to > >> look, and those looking to work on individual commands know to look > >> elsewhere. > > > > You missed a few (on purpose?): block-sha1, ppc and compat. > > Yes, on purpose. They're separately reusable.
I wonder if there should perhaps be lib/, with all of the libgit.a sources in it, and then lib/block-sha1, lib/ppc, lib/compat, etc. Those things do end up inside libgit.a, don't they?
-Peff