Re: [PATCH 3/6] web--browse: split valid_tool list

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Nov 29, 2010, 19:19 UTC
Message-ID: <AANLkTik7611p5gun+CmyvOVpcm=_dXVo9FzP_tw7cbRU@mail.gmail.com>
In-Reply-To: <20101129164435.GI8037@burratino>

On Mon, Nov 29, 2010 at 5:44 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 18 quoted lines

> Giuseppe Bilotta wrote:
>
>> --- a/git-web--browse.sh
>> +++ b/git-web--browse.sh
>> @@ -31,7 +31,8 @@ valid_custom_tool()
>>
>>  valid_tool() {
>>       case "$1" in
>> -     firefox | iceweasel | chrome | google-chrome | chromium | konqueror | w3m | links | lynx | dillo | open | start)
>> +     firefox|iceweasel|chrome|google-chrome|chromium\
>> +     |konqueror|w3m|links|lynx|dillo|open|start)
>
> micronit: I think this looks better as
>
>        firefox|iceweasel|chrome|google-chrome|chromium| \
>        konqueror|w3m|links|lynx|dillo|open|start)
>
> , with the | on the end of the first line.

I opted for the | at the beginning of the line to give a better idea of the continuation, but I don't have a strong preference in that direction, so I can fix it up as you suggested, unless there are specific indications from the 'higher ups' ;-)

-- 
Giuseppe "Oblomov" Bilotta