Re: [PATCH 3/6] web--browse: split valid_tool list

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 29, 2010, 20:24 UTC
Message-ID: <7vsjyj280k.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20101129164435.GI8037@burratino>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 18 quoted lines

> Giuseppe Bilotta wrote:
>
>> --- a/git-web--browse.sh
>> +++ b/git-web--browse.sh
>> @@ -31,7 +31,8 @@ valid_custom_tool()
>>  
>>  valid_tool() {
>>  	case "$1" in
>> -	firefox | iceweasel | chrome | google-chrome | chromium | konqueror | w3m | links | lynx | dillo | open | start)
>> +	firefox|iceweasel|chrome|google-chrome|chromium\
>> +	|konqueror|w3m|links|lynx|dillo|open|start)
>
> micronit: I think this looks better as
>
> 	firefox|iceweasel|chrome|google-chrome|chromium| \
> 	konqueror|w3m|links|lynx|dillo|open|start)
>
> , with the | on the end of the first line.

Yes, and with one SP around all "|".

Thanks.