Re: [PATCH 1/2] fast-import: filemodify after M 040000 <tree> "" crashes

From: Sverre Rabbelier <srabbelier@gmail.com>
Date: Oct 18, 2010, 01:13 UTC
Message-ID: <AANLkTik3iSSzKCxi9aeNw+ATPXvTN6yw-=NDGtqCidce@mail.gmail.com>
In-Reply-To: <20101018010338.GB25524@burratino>

Heya,

On Sun, Oct 17, 2010 at 20:03, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 11 quoted lines

> Until M 040000 <tree> "" syntax was introduced in commit 2794ad5
> (fast-import: Allow filemodify to set the root, 2010-10-10), it
> was impossible for the root entry to refer to an unloaded tree.
> Update various functions to take that possibility into account.
> Otherwise
>
>        M 040000 <tree> ""
>        M 100644 :1 "foo"
>
> and similar commands (using D, C, or R after resetting the root
> tree) segfault.

I'm curious, how come this not found earlier? Would seem like a fairly regular operation?

-- 
Cheers,

Sverre Rabbelier