Re: [PATCH] test-lib: use subshell instead of cd $new && .. && cd $old

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Aug 30, 2010, 16:01 UTC
Message-ID: <AANLkTi=z9uUB_YZ9Sb0O8JzaEjazKDzqB=ZVtqTTDf2K@mail.gmail.com>
In-Reply-To: <20100830155723.GC3292@burratino>

On Mon, Aug 30, 2010 at 15:57, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 25 quoted lines

> Ævar Arnfjörð Bjarmason wrote:
>
>> +++ b/t/test-lib.sh
>> @@ -687,14 +687,12 @@ test_when_finished () {
>>  test_create_repo () {
>>       test "$#" = 1 ||
>>       error "bug in the test script: not 1 parameter to test-create-repo"
>> -     owd=`pwd`
>>       repo="$1"
>>       mkdir -p "$repo"
>> -     cd "$repo" || error "Cannot setup test environment"
>> +     (cd "$repo" || error "Cannot setup test environment"
>>       "$GIT_EXEC_PATH/git-init" "--template=$GIT_BUILD_DIR/templates/blt/" >&3 2>&4 ||
>>       error "cannot run git init -- have you built things yet?"
>> -     mv .git/hooks .git/hooks-disabled
>> -     cd "$owd"
>> +     mv .git/hooks .git/hooks-disabled)
>
> Style: why not use
>
>        (
>                cd "$repo" ...
>                ... .git/hooks-disabled
>        )
>

I've seen both used and I don't know which is preferred.