Re: [PATCH] test-lib: use subshell instead of cd $new && .. && cd $old

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Aug 30, 2010, 16:04 UTC
Message-ID: <20100830160444.GE3292@burratino>
In-Reply-To: <AANLkTi=z9uUB_YZ9Sb0O8JzaEjazKDzqB=ZVtqTTDf2K@mail.gmail.com>

Ævar Arnfjörð Bjarmason wrote:

> On Mon, Aug 30, 2010 at 15:57, Jonathan Nieder <jrnieder@gmail.com> wrote:
>> Ævar Arnfjörð Bjarmason wrote:

Show 17 quoted lines

>>> -     cd "$repo" || error "Cannot setup test environment"
>>> +     (cd "$repo" || error "Cannot setup test environment"
>>>       "$GIT_EXEC_PATH/git-init" "--template=$GIT_BUILD_DIR/templates/blt/" >&3 2>&4 ||
>>>       error "cannot run git init -- have you built things yet?"
>>> -     mv .git/hooks .git/hooks-disabled
>>> -     cd "$owd"
>>> +     mv .git/hooks .git/hooks-disabled)
>>
>> Style: why not use
>>
>>        (
>>                cd "$repo" ...
>>                ... .git/hooks-disabled
>>        )
>>
>
> I've seen both used and I don't know which is preferred.

Okay. I maintain that the latter is way more readable. Is there any advantage to the former?

Whichever the project chooses can be enshrined in Documentation/CodingGuidelines, of course.