Re: What's cooking in git.git (Aug 2010, #04; Wed, 18)

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Aug 19, 2010, 12:48 UTC
Message-ID: <AANLkTi=z6rs5U8N_piUUzR=t6oSNNF02RxVCws-1YRS1@mail.gmail.com>
In-Reply-To: <4C6CE61F.7060305@viscovery.net>

On Thu, Aug 19, 2010 at 08:06, Johannes Sixt <j.sixt@viscovery.net> wrote:

Show 11 quoted lines

> and I see these warnings:
>
> In file included from compat/regex/regex.c:71:
> compat/regex/regex_internal.c: In function 're_string_reconstruct':
> compat/regex/regex_internal.c:696: warning: unused variable 'prev_valid_len'
> In file included from compat/regex/regex.c:78:
> compat/regex/regexec.c: In function 'check_arrival_add_next_nodes':
> compat/regex/regexec.c:3062: warning: unused variable 'err'
>
> This happens because RE_ENABLE_I18N is not defined by regex_internal.h. Is
> this how it is supposed to be?

I noted these in <1282015548-19074-1-git-send-email-avarab@gmail.com>, although I was off by one.

I haven't read all the relevant code, but we almost definitely do not want RE_ENABLE_I18N, since we aren't doing the relevant setlocale() things (and doing so breaks git, see the fix in the ab/i18n series in pu).

I was going to report this upstream once I got around to finding out what upstream *is*, I don't *think* gawk itself is the canonical upstream, they just copy it from somewhere else (again, I *think*).