Re: [PATCH] Fix compat/regex ANSIfication on MinGW

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 4, 2010, 05:22 UTC
Message-ID: <7vlj7ixetq.fsf@alter.siamese.dyndns.org>
In-Reply-To: <AANLkTikqWap4nUamS=bx6oJ7mhUTEkFWpf7Hf=Mv1Ek=@mail.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> Yeah, wasn't the only reason they were ANSI-fied because Junio had
> some script in the todo branch that explicitly used -Werror in
> conjunction with a warning for k&r declerations/

As a matter of principle, I'd really want my compilation to pass without any warning, so -Werror is likely to stay.

Having said that, the codepath in question is not something I'd be compiling myself very often, so I am not in a good position to vetting and maintaining the particular ANSIification patch. Personally I think the change to move "internal_function" to the front (which Karsten mentioned is consistent with the way how the same issue is handled elsewhere in msysgit port) would be cleaner than the change to remove it.

I'd ask folks involved in Windows port to decide.  Sorry for the trouble.