Re: What's cooking in git.git (Nov 2010, #03; Wed, 24)

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Nov 25, 2010, 18:06 UTC
Message-ID: <AANLkTi=hRk-bqNvvMRCmbSu8Mc4uux5aowgLGnPLnD4A@mail.gmail.com>
In-Reply-To: <AANLkTin-kF_+DKDAu=gt12WfOcEVJaED-Qny8sFQ=oKP@mail.gmail.com>

On Thu, Nov 25, 2010 at 18:55, Erik Faye-Lund <kusmabite@gmail.com> wrote:

Show 10 quoted lines

> On Thu, Nov 25, 2010 at 5:33 PM, Ævar Arnfjörð Bjarmason
> <avarab@gmail.com> wrote:
>> Anyway, if that works it's a cleaner way to disable it.
>>
>
> Yes, that works. But that is a work-around, not a solution. I already
> told the make system not to translate git, why should I have to
> anything else? In fact, I did exactly what the documentation at the
> top of the makefile told me to do. It says to set NO_GETTEXT, nothing
> about clearing NEEDS_LIBINTL.

Oh yeah that's definitely a bug that I need to solve. But that should just be something like:

ifdef NO_GETTEXT
    NEEDS_LIBINTL =
endif

Stuck in some strategic location. Then it all should just work.