Re: What's cooking in git.git (Nov 2010, #03; Wed, 24)

From: Erik Faye-Lund <kusmabite@gmail.com>
Date: Nov 25, 2010, 20:02 UTC
Message-ID: <AANLkTi=G0m_AY3PMVs93=u=cKtVrAjFD56KPURYAyhyh@mail.gmail.com>
In-Reply-To: <AANLkTi=hRk-bqNvvMRCmbSu8Mc4uux5aowgLGnPLnD4A@mail.gmail.com>

On Thu, Nov 25, 2010 at 7:06 PM, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 21 quoted lines

> On Thu, Nov 25, 2010 at 18:55, Erik Faye-Lund <kusmabite@gmail.com> wrote:
>> On Thu, Nov 25, 2010 at 5:33 PM, Ævar Arnfjörð Bjarmason
>> <avarab@gmail.com> wrote:
>>> Anyway, if that works it's a cleaner way to disable it.
>>>
>>
>> Yes, that works. But that is a work-around, not a solution. I already
>> told the make system not to translate git, why should I have to
>> anything else? In fact, I did exactly what the documentation at the
>> top of the makefile told me to do. It says to set NO_GETTEXT, nothing
>> about clearing NEEDS_LIBINTL.
>
> Oh yeah that's definitely a bug that I need to solve. But that should
> just be something like:
>
> ifdef NO_GETTEXT
>    NEEDS_LIBINTL =
> endif
>
> Stuck in some strategic location. Then it all should just work.
>

Well, there you go. That's one of the things that needs to get fixed ;)

I don't quite understand why you won't do it the way I just proposed (and IIRC a while ago by Hannes), though.