git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] commit: Append commit_list prefix in two function names.

From
Thiago Farina <tfransosi@gmail.com>
Date
Nov 29, 2010, 00:05 UTC
Message-ID
<AANLkTi=hBzyufVoPrWJ1ngjzc0CZ0e202MaBtke9s_eR@mail.gmail.com>
In-Reply-To
<20101127082933.GA24840@burratino>
On Sat, Nov 27, 2010 at 6:29 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Even if split up into multiple patches?  I don't think it makes much
> sense to say "functions in the commit_list API all start with
> commit_list_"
I didn't say that in the patch.
> while at the same time leaving half of the functions in
> the commit_list API without that suffix.
>

What's is the problem with this? I don't see a reason to do this to all the functions in the same time. I prefer to do this in small patches. But it seems Junio is not going to pick this up?

> By the way, how did this come up?  Presumably some particular code
> was confusing?

It became with the idea of API, we see this with strbuf and string_list. And this would be good to make the code more easy to read.

Previous: Jonathan Nieder
Message 5 of 5 in “commit: Append commit_list prefix in two function names.”
  1. commit: Append commit_list prefix in two function names.Thiago Farina, Nov 14, 2010
  2. Jonathan NiederNov 14, 2010
  3. Thiago FarinaNov 27, 2010
  4. Jonathan NiederNov 27, 2010
  5. Thiago FarinaNov 29, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.