From: Thiago Farina <tfransosi@gmail.com>
Date: Mon, 29 Nov 2010 00:05:09 GMT
Subject: Re: [PATCH] commit: Append commit_list prefix in two function names.
Message-ID: <AANLkTi=hBzyufVoPrWJ1ngjzc0CZ0e202MaBtke9s_eR@mail.gmail.com>
In-Reply-To: <20101127082933.GA24840@burratino>

On Sat, Nov 27, 2010 at 6:29 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Even if split up into multiple patches?  I don't think it makes much
> sense to say "functions in the commit_list API all start with
> commit_list_"
I didn't say that in the patch.

> while at the same time leaving half of the functions in
> the commit_list API without that suffix.
>
What's is the problem with this? I don't see a reason to do this to
all the functions in the same time. I prefer to do this in small
patches. But it seems Junio is not going to pick this up?

> By the way, how did this come up?  Presumably some particular code
> was confusing?
It became with the idea of API, we see this with strbuf and
string_list. And this would be good to make the code more easy to
read.