git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t7003: Use test_commit instead of custom function

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Sep 13, 2010, 12:11 UTC
Message-ID
<AANLkTi=1p7tTNfhX7_4vMPFGtRC=F14im3qo009RPJV9@mail.gmail.com>
In-Reply-To
<214E9A5B-E9CE-4B98-88EC-744DBE1F3C32@gernhardtsoftware.com>

On Mon, Sep 13, 2010 at 04:14, Brian Gernhardt <brian@gernhardtsoftware.com> wrote:

Show 10 quoted lines
>
> On Sep 10, 2010, at 6:06 PM, Brian Gernhardt wrote:
>
>> Not only is this unneeded code duplication, it also was something
>> simply waiting to fail on case-insensitive file systems.  So replace
>> all uses of make_commit with test_commit.
>
> To be more specific: this causes a failure in next on case-insensitive HFS+.  The commit that finally triggered the problem is 7ec344d: "filter-branch: retire --remap-to-ancestor", by using `git reset --hard A` which got confused on if 'A' was 'refs/branches/A' or './a'
>
> However, the patch applies to master or maint.

And you've modified the casing so it passes? Maybe it should skip on case-insensitive systems instead, or perhaps we should modify it and test for that elsewhere.

Previous: Brian GernhardtNext: Ævar Arnfjörð Bjarmason
Message 3 of 4 in “t7003: Use test_commit instead of custom function”
  1. t7003: Use test_commit instead of custom functionBrian Gernhardt, Sep 10, 2010
  2. Brian GernhardtSep 13, 2010
  3. Ævar Arnfjörð BjarmasonSep 13, 2010
  4. Ævar Arnfjörð BjarmasonSep 13, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.