Re: [PATCH/RFC v2 2/4] rev-parse: Don't recognise --flags as an option if --no-flags has been specified.
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Sep 25, 2010, 10:26 UTC
- Message-ID
- <AANLkTi=1UJ+BJGE+-CXXGsfGeNcejPUT=0BA5MSXjjSv@mail.gmail.com>
- In-Reply-To
- <1285405454-12521-4-git-send-email-jon.seymour@gmail.com>
On Sat, Sep 25, 2010 at 09:04, Jon Seymour <jon.seymour@gmail.com> wrote:
> + if (!(filter & DO_FLAGS)) {
> + // --preceding --no-flags means --flags is ignored
> + continue;
> + }Please use a /* C89 comment */, not the C++ / C99 style.